This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
feat: Adding a few new devices #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdot
reviewed
May 6, 2020
| @@ -236,7 +237,8 @@ | |||
| "btle": { | |||
| "names": [ | |||
| "Onyx2.1", | |||
| "Titan1.1" | |||
| "Titan1.1", | |||
| "Oynx+" | |||
There was a problem hiding this comment.
How is this in the JSON but not the YAML!?
There was a problem hiding this comment.
Damn. I forget to rebuild the JSON during my rebase.
Prior to your update (with the correct spelling) I had a similar changes with a typo in it.
I rebased out your yaml change but somehow auto-merged the json and forgot to regen...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Virtual Rabbit, LoveNutz and Vorze Cyclone
This PR includes the master commits which hadn't made it to dev yet (fast-forward only).